Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build updates #135

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Build updates #135

merged 1 commit into from
Jul 31, 2024

Conversation

phillipross
Copy link
Contributor

  • CI os updated from ubuntu-22.04 to ubuntu-24.04
  • CI java updated from zulu 8.0.392/11.0.21/17.0.9/21.0.1 to 8.0.422/11.0.24/17.0.12/21.0.4
  • CI maven updated from v3.9.6 to v3.9.8
  • build-helper-maven-plugin updated from v3.5.0 to v3.6.0
  • download-maven-plugin updated from v1.7.1 to v1.9.0
  • exec-maven-plugin updated from v3.1.1 to v3.3.0
  • jacoco-maven-plugin updated from v0.8.11 to v0.8.12
  • maven-assembly-plugin updated from v3.6.0 to v3.7.1
  • maven-checkstyle-plugin updated from v3.3.1 to v3.4.0
  • maven-clean-plugin updated from v3.3.2 to v3.4.0
  • maven-compiler-plugin updated from v3.11.0 to v3.13.0
  • maven-dependency-plugin updated from v3.6.1 to v3.7.1
  • maven-deploy-plugin updated from v3.1.1 to v3.1.2
  • maven-enforcer-plugin updated from v3.4.1 to v3.5.0
  • maven-failsafe-plugin updated from v3.2.2 to v3.3.1
  • maven-gpg-plugin updated from v3.1.0 to v3.2.4
  • maven-install-plugin updated from v3.1.0 to v3.1.2
  • maven-jar-plugin updated from v3.3.0 to v3.4.2
  • maven-javadoc-plugin updated from v3.6.3 to v3.8.0
  • maven-jxr-plugin updated from v3.3.1 to v3.4.0
  • maven-pmd-plugin updated from v3.21.2 to v3.24.0
  • maven-project-info-reports-plugin updated from v3.5.0 to v3.6.2
  • maven-release-plugin updated from v3.0.1 to v3.1.1
  • maven-shade-plugin updated from v3.5.1 to v3.6.0
  • maven-source-plugin updated from v3.3.0 to v3.3.1
  • maven-surefire-plugin updated from v3.2.2 to v3.3.1
  • maven-surefire-report-plugin updated from v3.2.2 to v3.3.1
  • spotbugs-maven-plugin updated from v4.8.2.0 to v4.8.6.2
  • versions-maven-plugin updated from v2.16.2 to v2.17.1
  • pmd updated from v6.55.0 to v7.4.0
  • slf4j updated from v2.0.9 to v2.0.13
  • spotbugs updated from v4.8.2 to v4.8.6

- CI os updated from ubuntu-22.04 to ubuntu-24.04
- CI java updated from zulu 8.0.392/11.0.21/17.0.9/21.0.1 to 8.0.422/11.0.24/17.0.12/21.0.4
- CI maven updated from v3.9.6 to v3.9.8
- build-helper-maven-plugin updated from v3.5.0 to v3.6.0
- download-maven-plugin updated from v1.7.1 to v1.9.0
- exec-maven-plugin updated from v3.1.1 to v3.3.0
- jacoco-maven-plugin updated from v0.8.11 to v0.8.12
- maven-assembly-plugin updated from v3.6.0 to v3.7.1
- maven-checkstyle-plugin updated from v3.3.1 to v3.4.0
- maven-clean-plugin updated from v3.3.2 to v3.4.0
- maven-compiler-plugin updated from v3.11.0 to v3.13.0
- maven-dependency-plugin updated from v3.6.1 to v3.7.1
- maven-deploy-plugin updated from v3.1.1 to v3.1.2
- maven-enforcer-plugin updated from v3.4.1 to v3.5.0
- maven-failsafe-plugin updated from v3.2.2 to v3.3.1
- maven-gpg-plugin updated from v3.1.0 to v3.2.4
- maven-install-plugin updated from v3.1.0 to v3.1.2
- maven-jar-plugin updated from v3.3.0 to v3.4.2
- maven-javadoc-plugin updated from v3.6.3 to v3.8.0
- maven-jxr-plugin updated from v3.3.1 to v3.4.0
- maven-pmd-plugin updated from v3.21.2 to v3.24.0
- maven-project-info-reports-plugin updated from v3.5.0 to v3.6.2
- maven-release-plugin updated from v3.0.1 to v3.1.1
- maven-shade-plugin updated from v3.5.1 to v3.6.0
- maven-source-plugin updated from v3.3.0 to v3.3.1
- maven-surefire-plugin updated from v3.2.2 to v3.3.1
- maven-surefire-report-plugin updated from v3.2.2 to v3.3.1
- spotbugs-maven-plugin updated from v4.8.2.0 to v4.8.6.2
- versions-maven-plugin updated from v2.16.2 to v2.17.1
- pmd updated from v6.55.0 to v7.4.0
- slf4j updated from v2.0.9 to v2.0.13
- spotbugs updated from v4.8.2 to v4.8.6

Signed-off-by: Phillip Ross <[email protected]>
Copy link

coderabbitai bot commented Jul 31, 2024

Walkthrough

Walkthrough

This update enhances the CI/CD pipeline and code quality configurations across several files. Key improvements include upgrading the operating system and JDK versions for better compatibility, refining Maven version rules, and adjusting PMD rules for code quality checks. Overall, these changes aim to optimize the build environment and address compatibility issues, ensuring a more robust and efficient development process.

Changes

Files Change Summary
.github/workflows/main.yml Upgraded OS to Ubuntu 24.04, updated JDK versions, incremented Maven version, adjusted build matrix settings, and upgraded GitHub Actions checkout/cache actions.
maven-version-rules.xml Modified regex rules for logback and added a rule to ignore version 7.10.x for testng, refining version exclusions.
pmd.xml Added new rules for PrimitiveWrapperInstantiation and EmptyControlStatement, while removing checks for various empty statements.
pom.xml Updated versions for multiple Maven plugins and dependencies, including pmd and slf4j, reflecting ongoing maintenance and performance improvements.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant CI/CD Pipeline
    participant Build Server
    participant Repository

    Developer->>CI/CD Pipeline: Push code changes
    CI/CD Pipeline->>Build Server: Trigger build process
    Build Server->>Repository: Fetch updated dependencies
    Build Server->>Build Server: Build project with new configurations
    Build Server->>CI/CD Pipeline: Return build results
    CI/CD Pipeline-->>Developer: Notify build status
Loading

🐰 In the meadow where code does flow,
Upgrades bloom and bugs do go.
With JDK and plugins refined,
A smoother path for all to find.
Let's hop with joy, let changes sing,
For a brighter build, let the code take wing! 🎉


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6e87082 and fe1cd90.

Files selected for processing (4)
  • .github/workflows/main.yml (3 hunks)
  • maven-version-rules.xml (2 hunks)
  • pmd.xml (3 hunks)
  • pom.xml (1 hunks)
Additional comments not posted (35)
maven-version-rules.xml (2)

15-15: Approved: Broadened exclusion range for logback versions.

The regex pattern for excluding logback versions has been updated to exclude versions 1.4 through 1.9, likely due to compatibility issues with Java versions.

However, ensure that the compatibility issues with these versions are well-documented.


28-28: Approved: Added exclusion for testng version 7.10.

A new regex pattern for excluding testng version 7.10 has been added, likely due to compatibility issues.

However, ensure that the compatibility issues with this version are well-documented.


</blockquote></details>
<details>
<summary>pmd.xml (3)</summary><blockquote>

`14-14`: **Approved: Added `PrimitiveWrapperInstantiation` rule.**

A new rule for `PrimitiveWrapperInstantiation` has been added to the best practices category, encouraging developers to avoid unnecessary use of wrapper classes.

---

`19-19`: **Approved: Added `EmptyControlStatement` rule.**

A new rule for `EmptyControlStatement` has been added to the code style category, promoting cleaner control flow structures.

---

`27-27`: **Verify the rationale behind the removal of error-prone rules.**

Multiple error-prone rules have been removed, suggesting a shift in prioritization of error detection. Ensure that the rationale behind these removals is well-documented.


.github/workflows/main.yml (4)

13-13: Approved: Upgraded operating system version.

The operating system version has been upgraded from Ubuntu 22.04 to Ubuntu 24.04, which may enhance compatibility and performance with newer software.


14-14: Approved: Updated JDK versions.

The JDK versions have been updated to more recent releases, ensuring the use of the latest features and improvements.


15-15: Approved: Updated Maven version.

The Maven version has been incremented from 3.9.6 to 3.9.8, ensuring the use of the latest features and improvements.


35-35: Approved: Updated GitHub Actions versions.

The GitHub Actions checkout and cache actions have been upgraded from version 3 to version 4, which may provide additional features or performance improvements in the CI/CD process.

Also applies to: 56-56

pom.xml (26)

117-117: Approved: Update of build-helper-maven-plugin to version 3.6.0

This update should include minor improvements and bug fixes.


119-119: Approved: Update of download-maven-plugin to version 1.9.0

This update should include minor improvements and bug fixes.


120-120: Approved: Update of exec-maven-plugin to version 3.3.0

This update should include minor improvements and bug fixes.


122-122: Approved: Update of jacoco-maven-plugin to version 0.8.12

This update should include minor improvements and bug fixes.


125-125: Approved: Update of maven-assembly-plugin to version 3.7.1

This update should include minor improvements and bug fixes.


126-126: Approved: Update of maven-checkstyle-plugin to version 3.4.0

This update should include minor improvements and bug fixes.


128-128: Approved: Update of maven-compiler-plugin to version 3.13.0

This update should include minor improvements and bug fixes.


129-129: Approved: Update of maven-dependency-plugin to version 3.7.1

This update should include minor improvements and bug fixes.


130-130: Approved: Update of maven-deploy-plugin to version 3.1.2

This update should include minor improvements and bug fixes.


133-133: Approved: Update of maven-enforcer-plugin to version 3.5.0

This update should include minor improvements and bug fixes.


134-134: Approved: Update of maven-failsafe-plugin to version 3.3.1

This update should include minor improvements and bug fixes.


135-135: Approved: Update of maven-gpg-plugin to version 3.2.4

This update should include minor improvements and bug fixes.


136-136: Approved: Update of maven-install-plugin to version 3.1.2

This update should include minor improvements and bug fixes.


137-137: Approved: Update of maven-jar-plugin to version 3.4.2

This update should include minor improvements and bug fixes.


139-139: Approved: Update of maven-javadoc-plugin to version 3.8.0

This update should include minor improvements and bug fixes.


140-140: Approved: Update of maven-jxr-plugin to version 3.4.0

This update should include minor improvements and bug fixes.


141-141: Approved: Update of maven-pmd-plugin to version 3.24.0

This update should include minor improvements and bug fixes.


142-142: Approved: Update of maven-project-info-reports-plugin to version 3.6.2

This update should include minor improvements and bug fixes.


143-143: Approved: Update of maven-release-plugin to version 3.1.1

This update should include minor improvements and bug fixes.


145-145: Approved: Update of maven-shade-plugin to version 3.6.0

This update should include minor improvements and bug fixes.


147-147: Approved: Update of maven-source-plugin to version 3.3.1

This update should include minor improvements and bug fixes.


148-148: Approved: Update of maven-surefire-plugin to version 3.3.1

This update should include minor improvements and bug fixes.


149-149: Approved: Update of maven-surefire-report-plugin to version 3.3.1

This update should include minor improvements and bug fixes.


151-151: Approved: Update of spotbugs-maven-plugin to version 4.8.6.2

This update should include minor improvements and bug fixes.


152-152: Approved: Update of versions-maven-plugin to version 2.17.1

This update should include minor improvements and bug fixes.


157-157: Verify compatibility with PMD version 7.4.0

This update is a major version increment and may include breaking changes. Ensure that the PMD rules and configurations are compatible with the new version.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@phillipross phillipross merged commit 8a47a6c into postgis:main Jul 31, 2024
4 checks passed
@phillipross phillipross deleted the main-updates branch August 1, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant