Fix final step of Windows auto-update #6117
Open
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
I've got a wiki update to describe the entire update process that is WIP: https://github.com/posit-dev/positron-wiki/tree/auto-updates
It describes the steps of the auto-update in detail for Windows that explains what the installer does to update Positron.
Add missing argument to inno_updater execution. It expects 3 arguments (exe path of existing installation, lock file status, and a string for the log). See https://github.com/microsoft/inno-updater/blob/3fc01e98dadd9b41fb8073f769fe0756a6f94cf9/src/main.rs#L546 (note that it does check for 4 but the first arg is
inno_updater.exe
)Without the last argument,
inno_updater.exe
exits without replacing the existing install with the updated one.New Features
Bug Fixes
QA Notes
This change is required so that the auto-update will complete successfully. Otherwise, the old installation will remain with the updated one located in the
<existing Positron path>\_\
directory.