-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python, linting: Align ruff with upstream #6066
base: main
Are you sure you want to change the base?
Conversation
E2E Tests 🚀 |
good start: |
618b518
to
4790fdd
Compare
This should be good to go; CI is green (though to be fair I'm still combing through the diff to make sure there's nothing unexpected 😄) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this looks like the upstream plus a couple fences.
d5dcc4f
to
96aeade
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking this one for the team 😄 I suggest manually running the E2E testing GH action against this branch before merging to main
as one added precaution given the size of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks great! this work is so appreciated, thank you for grabbing this issue!
post #6085 merge it does look like there are a bunch of conflicts 😬 lmk if you have any questions, it should just be renaming files 🤞
96aeade
to
ea16e02
Compare
Good idea; kicked off a full suite here
Luckily it wasn't bad at all! I don't know why the GitHub UI showed so many. Locally I only had to fix a couple imports in like 6 files. I didn't have to rename anything 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full test suite is green! ✅
Addresses #5667. This PR aligns the positron-python pyproject.toml with the upstream, which includes a lot of ruff linting.
Release Notes
New Features
Bug Fixes
QA Notes
This is a fairly big code change to the Python extension, but it's all linting, so I don't expect any behavior differences. I ran a full suite of tests. So I think we just want to be sure that Python comes up and we can use the kernel/console in a release build.