e2e-test: add savePlot #5479
Merged
e2e-test: add savePlot #5479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
The goal of this PR was to improve the test by removing a hardcoded wait that was previously required for the test to work and pass. I was able to make improvements to the test and it runs/passes but occasionally I kept running into a flake of RPC timeout on CI runs for the python plot test. Maybe that was the original issue? (The in-line comment didn't say). Adding the wait back in does seem to remove the flake, so maybe that was it after-all. Regardless, there are still improvements worth merging in.
Approach
A new method, savePlot, was introduced to encapsulate and enhance the logic for saving a plot to a selected file type. Additionally, some before/after hooks were cleaned up for better readability.
QA Notes