Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form-inputs-steps-for-actions #187

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

pazhersh
Copy link
Collaborator

@pazhersh pazhersh commented Sep 29, 2024

Description

What - add support for the new action step definition feature
How - added the relevant models and schemas + tests

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Copy link
Member

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs change (in schema.go) and make gen-docs

if len(a.Trigger.UserInputs.Order) > 0 {
state.SelfServiceTrigger.OrderProperties = flex.GoArrayStringToTerraformList(ctx, a.Trigger.UserInputs.Order)
} else {
state.SelfServiceTrigger.OrderProperties = types.ListNull(types.StringType)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pazhersh pazhersh merged commit 350e725 into main Sep 30, 2024
5 checks passed
@pazhersh pazhersh changed the title PORT-8983-form-inputs-sections-steps-for-actions form-inputs-steps-for-actions Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants