Add Integration Resource #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzaadi
force-pushed
the
PORT-8259-iac-for-integrations
branch
from
a373e61 to
10d1d8e
Compare
Tankilevitch
requested changes
Jun 4, 2024
1q
Outdated
Comment on lines
-33
to
-35
| run-example: | ||
| cd examples && terraform init && terraform apply | ||
|
|
There was a problem hiding this comment.
In the previous example refactor I changed it so that each example is ran per folder
Makefile
Outdated
Comment on lines
48
to
50
| lint: | ||
| # https://golangci-lint.run/welcome/install/#local-installation | ||
| golangci-lint run |
There was a problem hiding this comment.
can we add dev-install or something?
port/integration/schema.go
Outdated
Comment on lines
104
to
108
| webhook_changelog_destination = { | ||
| type = "WEBHOOK" | ||
| url = "https://google.com" | ||
| agent = true | ||
| } |
There was a problem hiding this comment.
lets remove it from the basic example, 99% of the users don't use it and we don't want them to create it by default
erikzaadi
force-pushed
the
PORT-8259-iac-for-integrations
branch
from
833f0f9 to
83556b4
Compare
erikzaadi
force-pushed
the
PORT-8259-iac-for-integrations
branch
from
83556b4 to
7ae7cb3
Compare
erikzaadi
force-pushed
the
PORT-8259-iac-for-integrations
branch
from
7ae7cb3 to
078bc8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Add a new Integration resource
Type of change