Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource from state when resource doesn't exist #148

Merged
merged 1 commit into from
May 19, 2024

Conversation

erikzaadi
Copy link
Member

@erikzaadi erikzaadi commented May 19, 2024

Description

What - Ensure that resources are removed from the state if the resource doesn't exist

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@erikzaadi erikzaadi requested a review from Tankilevitch May 19, 2024 06:49
@erikzaadi erikzaadi force-pushed the PORT-8111-remove-from-state-at-404 branch from b01cc0d to 7316182 Compare May 19, 2024 07:02
@erikzaadi erikzaadi changed the title Remove page permission from state when page is removed Remove resource from state when page is removed May 19, 2024
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🥇
Please update title accordingly

@erikzaadi erikzaadi changed the title Remove resource from state when page is removed Remove resource from state when resource doesn't exist May 19, 2024
@erikzaadi erikzaadi merged commit 7316182 into main May 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants