Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT-9474] Changed creation run method to support v2 actions #130

Merged
merged 25 commits into from
Aug 20, 2024

Conversation

matan84
Copy link
Member

@matan84 matan84 commented Aug 12, 2024

Description

What - Changed create runs route and body to support new v2 actions routing
Why - v1 deprecation
How - changed createRun file

Type of change

Please leave one option from the following and delete the rest:

  • New feature (non-breaking change which adds functionality)

Copy link
Contributor

@omby8888 omby8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the README.md is outdated as well, both in the yml example and in port icon if there is the new one (not mandatory)

Copy link
Contributor

@omby8888 omby8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matan84 matan84 merged commit d388840 into main Aug 20, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants