Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitOps guide - domain identifier param name in the input form #1304

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

thinkingabouther
Copy link
Contributor

@thinkingabouther thinkingabouther commented Jun 12, 2024

Description

In the guide describing the usage of port.yml file with GitOps approach, when the domain entity is pushed from the user's form to the Gitlab pipeline to create a new port.yml file, the full domain entity is populated inside the file instead of only the identifier, as needed for reletaion to work.
image

Updated docs pages

Please also include the path for the updated docs

  • Let developers enrich services using Gitops (/guides-and-tutorials/let-developers-enrich-services-using-gitops/)

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1304.d2ngvl90zqbob8.amplifyapp.com

@hadar-co
Copy link
Contributor

Hi @thinkingabouther, thank you for the PR 🚀

@hadar-co hadar-co merged commit 3e1c7fb into port-labs:main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants