-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][AWS] Fixed JSON key issues caused by custom properties enum #1277
Merged
oiadebayo
merged 12 commits into
main
from
PORT-12228-Bug-Mapping-of-AWSCloudFormationStack-fails-due-to-Invalid-Key-Formatting
Jan 9, 2025
Merged
[Integration][AWS] Fixed JSON key issues caused by custom properties enum #1277
oiadebayo
merged 12 commits into
main
from
PORT-12228-Bug-Mapping-of-AWSCloudFormationStack-fails-due-to-Invalid-Key-Formatting
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a test we can add?
…tack-fails-due-to-Invalid-Key-Formatting
…tack-fails-due-to-Invalid-Key-Formatting
…tack-fails-due-to-Invalid-Key-Formatting
…tack-fails-due-to-Invalid-Key-Formatting
shalev007
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oiadebayo
deleted the
PORT-12228-Bug-Mapping-of-AWSCloudFormationStack-fails-due-to-Invalid-Key-Formatting
branch
January 9, 2025 10:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - This PR addresses an issue where CustomProperties (a StrEnum) was being used as dictionary keys directly, causing invalid JSON/dictionary serialization by including both the enum key and value in the output. The fix ensures that only the StrEnum.value is used for dictionary keys.
Why - The existing implementation leads to serialization issues, creating invalid JSON or dictionaries that cannot be processed downstream
How - Updated all instances where CustomProperties is used as dictionary keys to explicitly use .value for their string representation
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.