bug fixes and cookiecutter

port-labs · Jun 29, 2023 · f39b6a9 · f39b6a9
1 parent e8a0bf9
commit f39b6a9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 33 deletions.
diff --git a/port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/Makefile b/port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/Makefile
@@ -37,14 +37,9 @@ define deactivate_virtualenv
     fi
 endef
 
-.SILENT: generate_config install lint run test clean
+.SILENT: install lint run test clean
 
-generate_config:
-	@if [[ ! -e .env ]]; then \
-		cp example.config.yaml config.yaml; \
-	fi
-
-install: generate_config
+install:
 	$(call deactivate_virtualenv) && \
 	$(call install_poetry) && \
 	poetry install --with dev

diff --git a/port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/example.config.yaml b/port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/example.config.yaml
diff --git a/port_ocean/core/handlers/port_app_config/models.py b/port_ocean/core/handlers/port_app_config/models.py
@@ -1,13 +1,12 @@
 from typing import Optional
 
-from pydantic import BaseModel, Field
-
 from port_ocean.clients.port.types import RequestOptions
+from pydantic import BaseModel, Field
 
 
 class EntityMapping(BaseModel):
     identifier: str
-    title: str
+    title: str | None
     blueprint: str
     properties: dict[str, str] = Field(default_factory=dict)
     relations: dict[str, str] = Field(default_factory=dict)

diff --git a/port_ocean/core/integrations/base.py b/port_ocean/core/integrations/base.py
@@ -4,7 +4,6 @@
 )
 
 from loguru import logger
-
 from port_ocean.clients.port.types import UserAgentType
 from port_ocean.context.event import (
     event_context,
@@ -38,7 +37,7 @@ async def _sync_new_in_batches(
 
         tasks = []
 
-        batch_size = self.context.config.batch_work_size or len(results)
+        batch_size = self.context.config.batch_work_size or len(results) or 1
         for batch in [
             results[i : i + batch_size] for i in range(0, len(results), batch_size)
         ]: