Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you have this library running in another computer with no control over the environment variables (A.K.A. user computer) and in a simple interface, the user expects for it to work as defined in the configuration, so an empty password input should be an empty password sent to postgres, not modified based on the environment variables.
Sometimes support tickets are tedious, so convincing a user that he has a
PGPASSWORD
env variable (for whatever reason) and the variable is affecting how he expects the configuration to work, is something I prefer to not fight for, hence I added ano_env
property to the configuration to avoid applying the env values. It is opt-in so is nothing that could break anything, I guess. If this way is not good, I still would like to discuss ways to avoid env to apply, apart from modifyingprocess.env
prior to the parsing, if possible.