Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add realizedollar for $0 receivers and comment out clip #2178

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ben-wes
Copy link
Contributor

@ben-wes ben-wes commented Sep 22, 2024

first step after a while for getting scope3d~ ready ...

@porres
Copy link
Owner

porres commented Sep 23, 2024

and why no clip no more?

@porres porres merged commit 0137581 into porres:master Sep 23, 2024
4 checks passed
@ben-wes
Copy link
Contributor Author

ben-wes commented Sep 23, 2024

and why no clip no more?

it's a huge pain performance-wise. the implementation is actually checking for every line whether it crosses the boundaries - and in that case shortens it accordingly. and since we discussed performance stuff, i'd strongly suggest not to add a feature that makes things even slower.

@porres
Copy link
Owner

porres commented Sep 23, 2024

is there a way to make it more efficient?

@porres
Copy link
Owner

porres commented Sep 23, 2024

I'm movint scope3d~ to a 'not yet' folder as I want to make a final release today or so as I can't hold it anymore :)

@ben-wes
Copy link
Contributor Author

ben-wes commented Sep 23, 2024

is there a way to make it more efficient?

not for vanilla. and for plugdata, it gets automatically clipped anyway.

I'm movint scope3d~ to a 'not yet' folder as I want to make a final release today or so as I can't hold it anymore :)

sure, go ahead! no problem from my side at all! there are no other pd-lua objects in else at the moment, right?

@porres
Copy link
Owner

porres commented Sep 23, 2024

for plugdata, it gets automatically clipped anyway.

why?

@porres
Copy link
Owner

porres commented Sep 23, 2024

there are no other pd-lua objects in else at the moment, right?

else/circle uses it, so I am shipping whatever the modified version I have right now... but I know new things are coming anyway

@porres
Copy link
Owner

porres commented Sep 23, 2024

but I know new things are coming anyway

I mean new pdlua versions

@ben-wes
Copy link
Contributor Author

ben-wes commented Sep 23, 2024

why?

because it handles drawing quite different.

else/circle uses it

i was asking because of the issue with instantiating else/scope3d~ ... does it work with else/circle?

@porres
Copy link
Owner

porres commented Sep 23, 2024

else/circle is a pd file abstraction, and it uses graphics internally. it's not a full blast coded in lua only object ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants