Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for Vaquita DFE #1547

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

igronau
Copy link
Contributor

@igronau igronau commented Feb 20, 2024

implemented model from Robinson et al. (2022), including documentation and the h-s relationship

added dcomentation to DFE and the h-s relationship

fixed import in PhoSin/__init__.py
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9f9086) 99.86% compared to head (b79c448) 99.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1547   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         130      131    +1     
  Lines        4319     4333   +14     
  Branches      594      594           
=======================================
+ Hits         4313     4327   +14     
  Misses          3        3           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@petrelharp petrelharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The h-s relationship looks correct to me (not checking the paper, but based on what's in the comments).

@petrelharp petrelharp merged commit fbb94c2 into popsim-consortium:main Feb 20, 2024
11 checks passed
@igronau
Copy link
Contributor Author

igronau commented Feb 20, 2024

Thanks, @petrelharp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants