Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AraTha DFE QC #1479

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

petrelharp
Copy link
Contributor

This is a work in progress; see #1344 for discussion.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (ff79d8d) to head (2e49b36).

❗ There is a different number of reports uploaded between BASE (ff79d8d) and HEAD (2e49b36). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (ff79d8d) HEAD (2e49b36)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1479       +/-   ##
===========================================
- Coverage   99.84%   85.92%   -13.92%     
===========================================
  Files         130      125        -5     
  Lines        4416     4205      -211     
  Branches      608      569       -39     
===========================================
- Hits         4409     3613      -796     
- Misses          3      579      +576     
- Partials        4       13        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrelharp
Copy link
Contributor Author

For reference:
Screenshot from 2023-05-16 09-54-33

@petrelharp
Copy link
Contributor Author

As discussed in #1344, we decided this wasn't actually the right DFE from that paper to implement. Leaving this open to remind me to deal with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant