Add support for drag-and-drop surface offsets #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first `map()` call is unneded, and the second and third can be combined. This seems a bit clearer.
This is not currently used. And is impossible to (soundly) use, since it requires a `Send` bound, which `State` and `Element` lack.
This makes it easier to add a field, and makes the handling of upcasting/downcasting a more organized.
wash2
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the same functionality as #134.
Still needs
libcosmicupdate to pass on offset on drag start, and provide a way to set the offset of the surface. This also doesn't seem to be working as expected currently....This also tries to clean up the way a tuple and
Box<dyn Any>was used to be a little more organized.