Align interface closer to designs #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-f0x
changed the title
4 tasks
git-f0x
force-pushed
the
master
branch
2 times, most recently
from
c1a5a87 to
6d5c919
Compare
git-f0x
force-pushed
the
master
branch
3 times, most recently
from
f21ea5f to
e632da1
Compare
|
This has been rebased, and is ready for review! @ids1024 :) |
ids1024
reviewed
Jan 14, 2025
ids1024
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56. Fixes #48, though the horizontal picker has slightly more height than it should, since there's some weird behavior with setting the width or height (e.g. Length::Shrink makes the picker take the entire screen, while Length::Fill makes it a smaller size), and making the height fixed could cause issues with different aspect ratios.
The toplevel title character limit is to reduce the chance of the close button being squished, and is temporary until iced is rebased, and the pin widget being used to place the button in the corner of the toplevel preview.
Should also fix the issue described in #30 (not sure why it was closed).
This makes the same change in the Makefile as the OSD rebase PR, since other repos use that prefix.