Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alt tab cycle #150

Closed
wants to merge 10 commits into from
Closed

feat: alt tab cycle #150

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bbf7061
do not close the service every time
wiiznokes Jul 3, 2024
15cc639
add debug variable to justfile
wiiznokes Jul 11, 2024
dc81dcd
re add if self.last_hide.elapsed().as_millis() > 100
wiiznokes Jul 11, 2024
f7c4966
remove comment
wiiznokes Jul 11, 2024
07ceaec
journald support
wiiznokes Jul 11, 2024
d7f3ea1
use debug log level when debug mode
wiiznokes Jul 11, 2024
798aca2
impl queue + some refractor
wiiznokes Jul 12, 2024
caaf6d4
use github fork instead of path
wiiznokes Jul 19, 2024
88ebb79
fix compile
wiiznokes Sep 18, 2024
a2a62ec
fix justfile
wiiznokes Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 67 additions & 76 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@ libcosmic = { git = "https://github.com/pop-os/libcosmic/", features = [
"xdg-portal",
] }
tracing = "0.1"
tracing-subscriber = { version = "0.3.18", default-features = false, features = [
"std",
"fmt",
"env-filter",
] }
tracing-journald = "0.3.0"
nix = { version = "0.27.1", features = ["process"] }
once_cell = "1.17"
pop-launcher = { git = "https://github.com/pop-os/launcher/", rev = "091581c" }
pop-launcher-service = { git = "https://github.com/pop-os/launcher/", rev = "091581c" }
pretty_env_logger = "0.5"
rust-embed = "6.3.0"
serde = { version = "1.0.152", features = ["derive"] }
serde_json = "1.0.91"
Expand All @@ -44,3 +49,7 @@ switcheroo-control = { git = "https://github.com/pop-os/dbus-settings-bindings"
zbus = { version = "4.2.1", default-features = false, features = ["tokio"] }
unicode-truncate = "1.0.0"
unicode-width = "0.1.11"

[patch."https://github.com/pop-os/launcher/"]
pop-launcher = { git = "https://github.com/wiiznokes/launcher/", rev = "86a54d54a68b832d404ef83a03af84cf9ef3e694" }
Copy link
Member

@jacobgkau jacobgkau Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we won't want to merge this reference to a fork into master.

If pop-os/launcher#227 doesn't cause any regressions for the pop-shell frontend on 22.04, then I can regression test that one and we can get it merged first, if that would help? (It'd be nice to be able to test that it works properly, and I can also still do that if we get this PR to build.)

Copy link
Contributor Author

@wiiznokes wiiznokes Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into it. I must say I ran into this problem, but the problem it's just the target/target (should be one target), so it's easy to work around it.

If you want to test the other pr, you must also install this one for it to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed. We probably want to merge

  1. client-toolkit: Add suport for cosmic-toplevel-info-v1 version 2 cosmic-protocols#35
  2. feat: alt tab cycle launcher#227
  3. this pr

pop-launcher-service = { git = "https://github.com/wiiznokes/launcher/", rev = "86a54d54a68b832d404ef83a03af84cf9ef3e694" }
7 changes: 4 additions & 3 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
name := 'cosmic-launcher'
export NAME := 'cosmic-launcher'
export APPID := 'com.system76.CosmicLauncher'

rootdir := ''
prefix := '/usr'
debug := '0'

base-dir := absolute_path(clean(rootdir / prefix))

export INSTALL_DIR := base-dir / 'share'

cargo-target-dir := env('CARGO_TARGET_DIR', 'target')
bin-src := cargo-target-dir / 'release' / name
bin-dst := base-dir / 'bin' / name
bin-src := if debug == '1' { cargo-target-dir / 'target/debug' / NAME } else { cargo-target-dir / 'target/release' / NAME }
bin-dst := base-dir / 'bin' / NAME

# Use mold linker if clang and mold exists.
clang-path := `which clang || true`
Expand Down
Loading