Use ext-session-lock protocol
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
force-pushed
the
sctk-session-lock_jammy
branch
from
e6a2a95 to
ded8b4f
Compare
ids1024
force-pushed
the
sctk-session-lock_jammy
branch
2 times, most recently
from
979ae40 to
b9cc69c
Compare
|
Now that pop-os/iced#71 is merged, this just needs pop-os/libcosmic#206. And the version of iced in libcosmic will need to be updated. |
|
@ids1024 can you make a PR to libcosmic to update iced there? |
ids1024
force-pushed
the
sctk-session-lock_jammy
branch
from
b9cc69c to
3eac044
Compare
jackpot51
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on pop-os/iced#71. Can be tested with either pop-os/cosmic-comp#203 or a recent version of Sway.
Setting focus to the text input doesn't seem to work properly. That doesn't seem to be related to the ext-session-lock protocol, though, since the surface has keyboard focus and is getting key press events.
Calling
process::exit(0)also doesn't work properly since the client can't exit until the server has processed theunlockcall, or the server will stay locked (for security).