-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies required during build process #154
Conversation
Which dependency is requiring GTK? |
It's because of rfd crate |
Hi all! I tried to follow the |
Looks like rfd can be used in a GTK-free way: https://docs.rs/rfd/0.12.1/rfd/#xdg-desktop-portal-backend |
Tested this and confirmed these are needed |
Yeah, I had to add gtk3 to the CI build in order to get cosmic-text to compile there: #158 |
README.md
Outdated
@@ -52,6 +52,10 @@ optionally (though the build-system might currently require these libraries): | |||
- libgbm-dev | |||
- libclang-dev | |||
- libpipewire-0.3-dev | |||
- librust-atk-dev | |||
- libgtk-3-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to eliminate this dependency from the project that's depending on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purged
"Me too": On Ubuntu 23.10, I was also unable to build cosmic-epoch without ( EDIT: Oh, sorry. I did not have |
might be worth adding merging this until the dependency is dropped. needed on a raspberry pi 5. |
clang and nasm is needed also |
This PR adds a few additional dependencies that I needed in order to build the master branch of
cosmic-epoch
.It adds these packages to optional dependencies and the commands to install all dependencies and optional dependencies:
libpam0g-dev
libgtk-3-dev
build-essential
librust-atk-dev
libatk1.0-dev
As an example of the issues I would run into without these dependencies, here's the reason I needed
librust-atk-dev
libatk1.0-dev
: