-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix context menu styling #890
Conversation
Also improves the styling of resize indicators, and removes the unnecessary `.density()` method call for the SSD header.
Thanks for working on this!
Possibly this isn't reload correctly (or even initially), since we can't rely on libcosmic's App implementation to do that for us. E.g.: https://github.com/pop-os/cosmic-comp/blob/master/src/shell/mod.rs#L3700
If that is not a new problem we can ignore that for now.
Libcosmic updates have broken things in cosmic comp in the past given the unusual integration.
|
Everything listed seems to work as expected. :) |
Great. Good for merge then imo.
If it works with explicit |
Context menu still doesn't respect the style ( |
The selection highlights do change, so this might be a simple fix (other context menus have the same issue). I'll see if I can fix it. |
This should fix it: #935. |
This makes the menu match other context menus in COSMIC, and ensures some spacing between the shortcut and title. Tried to make the menu change with Density (hence the libcosmic update), but it didn't seem to change anything, regardless of the way of incorporating the spacing variables.
(Edit: Not sure why the text color of the title is the same as the shortcut. I've tried switching the title back to how it was, but it didn't change. But this is also the case in menus in apps)
Also tweaked the resize indicators for better styling. The right indicator still gets cut off slightly at smaller window widths, but not sure why that happens.
The centering of the SSD header title has a minor issue in some apps at minimum widths (only saw it on GitHub desktop so far; other apps have higher minimum widths), but not sure how that can be avoided. Changing the
header_bar
in libcosmic can improve this, but it also messes up COSMIC app headers.