input: Rework PointerFocus to operate directly on WlSurface #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #322 to eventually bump smithay again.
This takes about half of @ids1024 original approach, by leaving the
KeyboardFocusTarget
as is and adjusting thePointerFocusTarget
to go all the way and split upCosmicMapped
focus into iced-UI and surfaces.Reasoning:
WlSurface
variant is a good idea, as we are loosing context. The old PR spent quite a bit of code to reconstruct toplevel-surfaces. Let's simply not do that.CosmicWindow
and especially inCosmicStack
to make the window unaware of the decorations and provide proper wl_poiinter events. All of this is brittle and in some parts even straight up buggy (for admittedly rare input combinations). Lets split the focus in the actual window surface(s) and the decorations to fix this.Remaining TODOs:
element_under
#341