tiling: Check for popups before tiles in element_under

Cargo.toml

@@ -108,4 +108,4 @@ inherits = "release"
 lto = "fat"
 
 [patch."https://github.com/Smithay/smithay.git"]
-smithay = {git = "https://github.com/smithay//smithay", rev = "c17297b"}
+smithay = {git = "https://github.com/pop-os/smithay", branch = "fix-iteration"}

src/shell/element/mod.rs

@@ -816,6 +816,16 @@ impl CosmicMapped {
             CosmicMappedInternal::_GenericCatcher(_) => {}
         }
     }
+
+    pub fn is_in_popup_input_region(&self, point: &Point<f64, Logical>) -> bool {
+        match &self.element {
+            CosmicMappedInternal::Window(w) => w.is_in_popup_input_region(point),
+            CosmicMappedInternal::Stack(s) => s.is_in_popup_input_region(point),
+            CosmicMappedInternal::_GenericCatcher(_) => {
+                unreachable!()
+            }
+        }
+    }
 }
 
 impl IsAlive for CosmicMapped {

src/shell/element/stack.rs

@@ -605,6 +605,14 @@ impl CosmicStack {
     pub(crate) fn force_redraw(&self) {
         self.0.force_redraw();
     }
+
+    pub fn is_in_popup_input_region(&self, point: &Point<f64, Logical>) -> bool {
+        self.0.with_program(|p| {
+            let active = p.active.load(Ordering::SeqCst);
+            let windows = p.windows.lock().unwrap();
+            windows[active].is_in_popup_input_region(point)
+        })
+    }
 }
 
 #[derive(Debug, Clone, Copy)]

src/shell/element/surface.rs

@@ -14,7 +14,8 @@ use smithay::{
         ImportAll, Renderer,
     },
     desktop::{
-        space::SpaceElement, utils::OutputPresentationFeedback, PopupManager, Window, WindowSurface,
+        space::SpaceElement, utils::OutputPresentationFeedback, PopupManager, Window,
+        WindowSurface, WindowSurfaceType,
     },
     input::{
         keyboard::{KeyboardTarget, KeysymHandle, ModifiersState},
@@ -37,7 +38,7 @@ use smithay::{
         },
         wayland_server::protocol::wl_surface::WlSurface,
     },
-    utils::{user_data::UserDataMap, IsAlive, Logical, Rectangle, Serial, Size},
+    utils::{user_data::UserDataMap, IsAlive, Logical, Point, Rectangle, Serial, Size},
     wayland::{
         compositor::{with_states, SurfaceData},
         seat::WaylandFocus,
@@ -597,6 +598,15 @@ impl CosmicSurface {
     pub fn x11_surface(&self) -> Option<&X11Surface> {
         self.0.x11_surface()
     }
+
+    pub fn is_in_popup_input_region(&self, point: &Point<f64, Logical>) -> bool {
+        self.0
+            .surface_under(
+                *point,
+                WindowSurfaceType::POPUP | WindowSurfaceType::SUBSURFACE,
+            )
+            .is_some()
+    }
 }
 
 impl IsAlive for CosmicSurface {

src/shell/element/window.rs

@@ -249,6 +249,11 @@ impl CosmicWindow {
     pub(crate) fn force_redraw(&self) {
         self.0.force_redraw();
     }
+
+    pub fn is_in_popup_input_region(&self, point: &Point<f64, Logical>) -> bool {
+        self.0
+            .with_program(|p| p.window.is_in_popup_input_region(point))
+    }
 }
 
 #[derive(Debug, Clone, Copy)]

src/shell/layout/tiling/mod.rs

@@ -3113,11 +3113,9 @@ impl TilingLayout {
         }
 
         if matches!(overview, OverviewMode::None) {
+            // first check popups
             for (mapped, geo) in self.mapped() {
-                if !mapped.bbox().contains((location - geo.loc).as_logical()) {
-                    continue;
-                }
-                if mapped.is_in_input_region(
+                if mapped.is_in_popup_input_region(
                     &((location_f64 - geo.loc.to_f64()).as_logical()
                         + mapped.geometry().loc.to_f64()),
                 ) {