Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set the workspace of the activated token's surface to urgent if not focusing it #225

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: set the workspace of the activated token's surface to urgent if not focusing it #225

merged 1 commit into from
Nov 16, 2023

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Nov 16, 2023

This seems to fix an issue where the workspace for the activated settings wasn't appearing as urgent when spawning another instance of settings by the launcher from another workspace. Is this not intended?

@wash2 wash2 requested a review from Drakulix November 16, 2023 17:03
Drakulix
Drakulix approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! No not intended, just a hole in the logic, I didn't think of.

@Drakulix Drakulix merged commit 495d772 into master_jammy Nov 16, 2023
1 check passed
@wash2 wash2 deleted the fix-activation-urgent_jammy branch November 16, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakulix Drakulix Drakulix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wash2 @Drakulix