-
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Handle Additional GitHub secondary rate limit failure (#68)
We previously handled secondary rate limit errors, however, it turns out that we aren't getting the exception type that we were seeing then for all secondary rate limits. This PR updates to handle the generic "GitHubException" that PyGitHub uses. If we get the more generic error and it contains a secondary rate limit message from GitHub, we will handle with our usual "wait and try again" strategy.
- Loading branch information
1 parent
b13f9b4
commit 28b5d83
Showing
2 changed files
with
18 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
## Handle Additional GitHub secondary rate limit failure | ||
|
||
In our previous version, we added support for retrying when a secondary rate limit failure occurred. However, since that time, we have seen secondary rate limit failures that are not handled by the previous fix. This update adds a retry for the one time we know that the limit can be triggered. If the rate limit is triggered, the bot will wait for 30 seconds before trying again. If it encounters 5 failures, it will give up and quit. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters