UE2Rigify - Custom Rig Template Path #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thanks! I will approve and run tests after I finish making some final changes tomorrow |
- Removed unnecessary requirements - Removed some unused imports - Removed CUSTOM_RIG_TEMPLATES_PATH constant - Fixed create new template issue of not adding the default metarig right away if selected starter for some reason isn't a Rigify default - Moved get_rig_template_path() to utilities (second guessing this change)
|
Apologies for the delay. I've finished making the changes and solved an issue with creating new templates. I'm second guessing moving get[_custom]_rig_template_path to utilities, but it's used in more than one location (templates and Scene) so I decided to move it. |
JoshQuake
changed the title
|
Ill pull this into its own branch so we can run the tests first. Ill re-open to main from there |
JoshQuake
added a commit
that referenced
this pull request
Jul 30, 2024
* Feature: Adding an option for custom template path * restructure and small changes - Removed unnecessary requirements - Removed some unused imports - Removed CUSTOM_RIG_TEMPLATES_PATH constant - Fixed create new template issue of not adding the default metarig right away if selected starter for some reason isn't a Rigify default - Moved get_rig_template_path() to utilities (second guessing this change) --------- Co-authored-by: Alexander Dmitriev <[email protected]> Co-authored-by: JoshQuake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is adding an ability to choose a template path on where to store your rig templates.
It should mitigate an issue when by default templates are stored in Temp folder and once the folder is being cleaned up it also purges your custom templates.
This won't be happening anymore.