Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send to Unreal - macos and linux support #34

Merged
merged 11 commits into from
Jul 11, 2024
Merged

Send to Unreal - macos and linux support #34

merged 11 commits into from
Jul 11, 2024

Conversation

jack-yao91
Copy link

  • changed default multicast endpoint to 0.0.0.0 for unreal project
  • Updated quick start docs to show this
  • Made default command endpoint 127.0.0.1 on windows. Works cause multicast endpoint 0.0.0.0 binds to all network interfaces.
  • Made default command endpoint 0.0.0.0 on other systems.
  • Made command endpoint configurable

JoshQuake and others added 8 commits June 20, 2024 14:44
@JoshQuake
Migrated latest remote_execution.py from UE Python plugin
5acdeb5 
no coding changes, just updated comments
@JoshQuake
Solution attempts 1
639b537 
These are my current possible solutions that I need tested by mac users.
 - Increased node discovery sleep to 1s from 0.1s
 - Setting default bind addresses to 127.0.0.1 if on windows else 0.0.0.0
@JoshQuake
prints and attempt 2
64d412f 
- mostly prints to see how far it gets
- set rpc_response_timeout to 60 instead of fetching from send2ue prefs
@JoshQuake
adds user editable remote settings
24a0b39 
 - Remote execution settings added to addon preferences
 - Default bind addresses changed to 0.0.0.0
 - attempting to change RPC server ip based on OS. RPC on Windows doesn't allow 0.0.0.0

Issues:
 - Finds node but freezes for multiple seconds and reports no unreal instance found
@JoshQuake
added update_config function to remote exec
38b1c40 
created config update function for RemoteExecutionConfig
 - called when initializing and starting. Addon preferences dont exist right away so it reverts to built in defaults on launch using the tryexcept
@jack-yao91
initial pass at mac and window support
daf8188
@jack-yao91
updated unreal multicast endpoint and updated docs
4edd002
@jack-yao91
updated comment
d5ea5c8
@jack-yao91 jack-yao91 requested a review from JoshQuake July 10, 2024 22:24
@jack-yao91
Copy link
Author

jack-yao91 commented Jul 10, 2024 •
edited
Loading

I think this should work. Could the MacOS and linux users give this a try?
#19
#25

JoshQuake
JoshQuake approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@JoshQuake JoshQuake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed an unused 'import platform' in dependencies/rpc/client.py otherwise looks good and works from a Windows standpoint. I'm unable to test macOS

send2ue/dependencies/rpc/client.py Outdated Show resolved Hide resolved
This was linked to issues Jul 11, 2024
Send to Unreal - Not working on mac #19
Closed
Send2ue 2.4.3 "No instance of UnrealEditor found" on Linux/Debian 12 #25
Closed
Send to Unreal - Could not find an open Unreal Editor Instance #33
Closed
@jack-yao91 jack-yao91 merged commit 2a1df4d into main Jul 11, 2024
4 checks passed
@jack-yao91 jack-yao91 deleted the send2ue-macos-linux branch July 11, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshQuake JoshQuake JoshQuake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jack-yao91 @JoshQuake