Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UE to Rigify version condition #17

Merged
merged 11 commits into from
Jun 16, 2024
Merged

Fixed UE to Rigify version condition #17

merged 11 commits into from
Jun 16, 2024

Conversation

jack-yao91
Copy link

  • Fixed the conditional for the version, since a tupler doesn't know how to use a < on its members. Also since the major version is 4 that the issue start cropping up I just check if major version is below 4.
  • Also made RIG_TEMPLATES_PATH a staticmethod so it would evaluate when called. I believe bpy.app is None while the addon is activating
  • Threw the outline toggle in a try except. (Still need to figure out the correct calls. Apparently it still doesnt think the outliner is active even after overriding the context.)

@jack-yao91 jack-yao91 requested a review from JoshQuake June 14, 2024 14:17
Copy link
Collaborator

@JoshQuake JoshQuake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needing solution to toggle_expand_in_outliner

solved overriding context. If it can be optimized, feel free.
@JoshQuake
Copy link
Collaborator

Hmmm it's working on 3.6, 4,0, and 4,1 when I test manually.

@JoshQuake JoshQuake merged commit ad35489 into main Jun 16, 2024
4 checks passed
@JoshQuake JoshQuake deleted the ue2rigify-fixes branch June 17, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants