Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run Packit on commit events as well #527

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mrc0mmand
Copy link
Member

Let's do a Packit build on "commit" events as well, which automagically enables Packit's OpenScanHub integration [0].

Since OSH runs only on x86_64 Fedora Rawhide builds, let's limit the scope for the "commit" event adequately; we still do the usual builds across all supported Fedora releases (and architectures) in PRs.

The OSH integration is still in its experimental stage, but there's a plan to add SARIF support and integrate it into GitHub's UI (see [1]), which should make it quite useful.

[0] https://packit.dev/posts/openscanhub-prototype
[1] packit/dashboard#441


Note: this won't have any effect until it's merged, as OSH needs at least one build from the default (main) branch to have something to compare against.

Let's do a Packit build on "commit" events as well, which automagically
enables Packit's OpenScanHub integration [0].

Since OSH runs only on x86_64 Fedora Rawhide builds, let's limit the
scope for the "commit" event adequately; we still do the usual builds
across all supported Fedora releases (and architectures) in PRs.

The OSH integration is still in its experimental stage, but there's a
plan to add SARIF support and integrate it into GitHub's UI (see [1]),
which should make it quite useful.

[0] https://packit.dev/posts/openscanhub-prototype
[1] packit/dashboard#441
@siteshwar
Copy link

siteshwar commented Nov 13, 2024

An example Polkit scan can be seen at https://openscanhub.fedoraproject.org/task/23951/.

@evverx
Copy link

evverx commented Nov 13, 2024

Nice!

(I still think it would be great if it was possible to (optionally) bring clang back :-))

@siteshwar
Copy link

(I still think it would be great if it was possible to (optionally) bring clang back :-))

@lachmanfrantisek @lbarcziova It is possible to do it through --analyzer option of osh-cli and support for it should be added to Packit configurations.

@lbarcziova
Copy link

lbarcziova commented Nov 13, 2024

@siteshwar I assume this is what packit/packit#2391 would solve, right? We may prioritise that.

@siteshwar
Copy link

siteshwar commented Nov 13, 2024

@siteshwar I assume this is what packit/packit#2391 would solve, right? We may prioritise that.

I believe that issue is too generic and unless you are planning to design how the configurations may look in advance, each option may have to be taken individually based on user requests.

@jrybar-rh jrybar-rh merged commit a8ac3f6 into polkit-org:main Nov 14, 2024
33 checks passed
@mrc0mmand mrc0mmand deleted the packit-osh branch November 14, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants