test: run dfuzzer against Polkit's D-Bus interface #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
evverx
reviewed
Nov 11, 2024
evverx
reviewed
Nov 11, 2024
evverx
reviewed
Nov 11, 2024
Let's run dfuzzer to fuzz polkit's own D-Bus interface to catch issues like [0][1][2] early. The test implementation is a _bit_ convoluted, caused by the fact that we have to rebuild polkit with Address and Undefined sanitizers to make dfuzzer considerably more effective. This also involves running the just built polkit in a lightweight container so we don't mess with the already installed polkit (which could affect tests running after this one that don't expect sanitized polkit). All this extra code can be potentially dropped once we're able to do multiple Packit builds in one PR (currently in an RFC stage). Resolves: polkit-org#515 [0] polkit-org#506 [1] polkit-org@b709b69 [2] polkit-org@5cce296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's run dfuzzer to fuzz polkit's own D-Bus interface to catch issues
like [0][1][2] early.
The test implementation is a bit convoluted, caused by the fact that
we have to rebuild polkit with Address and Undefined sanitizers to make
dfuzzer considerably more effective. This also involves running the just
built polkit in a lightweight container so we don't mess with the
already installed polkit (which could affect tests running after this
one that don't expect sanitized polkit). All this extra code can be
potentially dropped once we're able to do multiple Packit builds in one
PR (currently in an RFC stage).
Resolves: #515
[0] #506
[1] b709b69
[2] 5cce296