fix(python): Allow is_in values to be given as custom Collection
#20801
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
c-peters,
MarcoGorelli and
reswqa
as code owners
alexander-beedie
force-pushed
the
is-in-collection
branch
from
980870a to
c1f906d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20801 +/- ##
==========================================
- Coverage 79.78% 79.78% -0.01%
==========================================
Files 1561 1561
Lines 222015 222029 +14
Branches 2533 2533
==========================================
+ Hits 177135 177136 +1
- Misses 44296 44309 +13
Partials 584 584 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20784.
The
isinstancecheck foris_inconstraint values was a little too restrictive.