[Core] Deploying all-the-protocol-actors #710

0xBigBoss · 2023-04-30T03:10:13Z

Description

Adds necessary updates to begin deploying different kind of actor nodes for Pocket Network. It is still incomplete according to #613 .

Issue

Fixes #613

Type of change

Please mark the relevant option(s):

List of changes

Updates localnet to support deploying different actors
Adds new config protos for enabling various actors
Creates and starts new actor specific utility module
Adds new RPC routes
- /v1/query/nodeRoles
Adds new CLI command bin/p1 query noderoles for querying a nodes roles
Stub HandleRelay
Converts "" to ":memory:" to be explicit about using in memory stores

Testing

make develop_test; if any code changes were made
Docker Compose LocalNet; if any major functionality was changed or introduced
k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
I have tested my changes using the available tooling
I have updated the corresponding CHANGELOG

If Applicable Checklist

I have updated the corresponding README(s); local and/or global
I have added tests that prove my fix is effective or that my feature works
I have added, or updated, mermaid.js diagrams in the corresponding README(s)
I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

Olshansk

Just wanted to ACK that I saw the PR (ty) and it's on my backlog for this week!

Makefile

Olshansk

Looks pretty good to me for the most part. Good foundation to add things to in the future.

Note that you'll have to rebase on top of @h5law's changes (already in) and @okdas has #727 in progress. @gokutheengineer is also going to submit a version of state sync for review soon.

Everything is in 🛫

build/config/genesis.json

build/config/fisherman.json

build/localnet/README.md

rpc/handlers_servicer.go

runtime/configs/proto/fisherman_config.proto

utility/validator/module.go

runtime/configs/config.go

utility/fisherman/module.go

okdas

Please excuse my lack of understanding. While reviewing the config file, I noticed that it seems to allow one process to serve as different actors. Is this the intended behavior? I was under the impression that we were not going to support this functionality.

For example, if one process has fisherman.enabled=true and servicer.enabled=true, would that be considered valid? Or is the configuration file looks that way to follow the module approach, where each module has its own property in the config file?

build/localnet/README.md

build/localnet/manifests/cli-client.yaml

build/localnet/Tiltfile

0xBigBoss · 2023-05-07T03:38:43Z

Please excuse my lack of understanding. While reviewing the config file, I noticed that it seems to allow one process to serve as different actors. Is this the intended behavior? I was under the impression that we were not going to support this functionality.

For example, if one process has fisherman.enabled=true and servicer.enabled=true, would that be considered valid? Or is the configuration file looks that way to follow the module approach, where each module has its own property in the config file?

AFAIK only a validator and servicer can co-exist in the same node. All other roles are exclusive to one another (a validator cannot be a fisherman, a servicer cannot be a fisherman). This will all be enforced in the utility module.

Olshansk · 2023-05-12T19:19:24Z

@0xBigBoss Can you rebase on top of @okdas's PR (#727) once it is merged in?

0xBigBoss · 2023-06-06T15:14:38Z

@0xBigBoss Left a couple small NITS, but otherwise the changes LGTM as long as the tests pass. I've added the e2e-devnet-test label to spin up a devnet for this.

Were there any other changes you were planning on doing or is it good to approve?

@Olshansk sorry didn't see that other service module after I rebased. I merged them and tried to clean it up a bit more, but I think it's ready to go,

Olshansk

A few more minor NITS but otherwise LGTM. Will approve after latest changes.

@adshmh Please prioritize taking a look at this as it conflicts with your work but I want us to merge it in sooner rather than later.
@0xBigBoss Please make sure unit tests and E2E tests are passing (green CI)

utility/module.go

utility/servicer/module.go

utility/session.go

…ore-deploying-all-the-actors

0xBigBoss · 2023-06-07T01:15:35Z

@Olshansk should be GTG, i had to update some of the stuff for e2e tests due to not using the default namespace.

Olshansk

Let's merge it in once CI is all 🟢 !

0xBigBoss · 2023-06-08T03:01:34Z

Thanks @Olshansk, gonna merge now since the checks failing are for off by one day for the changelogs and the codecov plugin failing on a lot of the code that got merged in from main.

…ider * pokt/main: Consensus/readme (#777) chore: add `--build-tags` flag to `go_lint` make target (#807) [Core] Deploying all-the-protocol-actors (#710) Add github wiki tag to devlog8 Add README for Devlog8 for iteration17 (#805)

## Description Adds necessary updates to begin deploying different kind of actor nodes for Pocket Network. It is still incomplete according to #613 . ## Issue Fixes #613 ## Type of change Please mark the relevant option(s): - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [x] Major breaking change - [x] Documentation - [x] Development Tools ## List of changes - Updates localnet to support deploying different actors - Adds new config protos for enabling various actors - Creates and starts new actor specific utility module - Adds new RPC routes - /v1/query/nodeRoles - Adds new CLI command `bin/p1 query noderoles` for querying a nodes roles - Stub `HandleRelay` - Converts "" to ":memory:" to be explicit about using in memory stores ## Testing - [x] `make develop_test`; if any code changes were made - [x] [Docker Compose LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md); if any major functionality was changed or introduced - [x] [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any infrastructure or configuration changes were made ## Required Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added, or updated, [`godoc` format comments](https://go.dev/blog/godoc) on touched members (see: [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment)) - [x] I have tested my changes using the available tooling - [x] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [x] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s) --------- Co-authored-by: github-actions <[email protected]>

…ider * pokt/main: Consensus/readme (#777) chore: add `--build-tags` flag to `go_lint` make target (#807) [Core] Deploying all-the-protocol-actors (#710) Add github wiki tag to devlog8 Add README for Devlog8 for iteration17 (#805)

* pokt/main: Consensus/readme (#777) chore: add `--build-tags` flag to `go_lint` make target (#807) [Core] Deploying all-the-protocol-actors (#710) Add github wiki tag to devlog8 Add README for Devlog8 for iteration17 (#805)

* refactor/peerstore-provider: (22 commits) fix: bugs chore: update changelogs refactor: rename `T` & `K` type params to `M` &`C` chore: improve comment chore: add issue numbers to TECHDEBT comments chore: add TECHDEBT comments refactor: re-implement `GetUnstakedPeerstore` refactor: update peerstore provider method receivers refactor: `p2pPeerstoreProvider` to a single function' refactor: rename persistence.go back to provider.go refactor: consolidate p2pPeerstoreProvider into persistencePeerstorProvider chore: oneline function signature refactor: embed `p2pPStoreProviderFactory` refactor: persistence peerstor provider Consensus/readme (#777) chore: add `--build-tags` flag to `go_lint` make target (#807) [Core] Deploying all-the-protocol-actors (#710) fix: retrieve p2p mdoule from bus on each call chore: add godoc comments chore: remove unused `GetP2PConfig()` method ...

0xBigBoss requested review from Olshansk and okdas April 30, 2023 03:10

0xBigBoss self-assigned this Apr 30, 2023

reviewpad bot added large waiting-for-review labels Apr 30, 2023

0xBigBoss mentioned this pull request Apr 30, 2023

[Core] Deploying all-the-protocol-actors #613

Closed

15 tasks

0xBigBoss force-pushed the 0xbigboss/dw-1860/core-deploying-all-the-actors branch 3 times, most recently from 213cec4 to 27e6ae5 Compare May 2, 2023 02:18

Olshansk reviewed May 2, 2023

View reviewed changes

Makefile Show resolved Hide resolved

Olshansk requested changes May 4, 2023

View reviewed changes

0xBigBoss force-pushed the 0xbigboss/dw-1860/core-deploying-all-the-actors branch from b6be2a9 to 8549297 Compare May 5, 2023 03:18

okdas reviewed May 5, 2023

View reviewed changes

build/localnet/README.md Show resolved Hide resolved

build/localnet/manifests/cli-client.yaml Show resolved Hide resolved

build/localnet/Tiltfile Outdated Show resolved Hide resolved

0xBigBoss force-pushed the 0xbigboss/dw-1860/core-deploying-all-the-actors branch 5 times, most recently from 0988dd3 to 54771d3 Compare May 7, 2023 16:10

0xBigBoss added 3 commits May 13, 2023 23:38

📝 🧬🎣🚪 all actor configs

9ba8871

Add /v1/query/nodeRoles RPC endpoint and localnet updates

1d79321

update docs

9603a6f

0xBigBoss added 3 commits June 6, 2023 10:52

merge service and servicer modules

cd5942d

check if cast works

ebdf98c

clean up get modules

d222dba

fix the interfaces

ec97a7f

Olshansk requested review from Olshansk, okdas and h5law June 6, 2023 20:12

Olshansk requested changes Jun 6, 2023

View reviewed changes

utility/module.go Outdated Show resolved Hide resolved

utility/module.go Outdated Show resolved Hide resolved

utility/servicer/module.go Outdated Show resolved Hide resolved

utility/session.go Outdated Show resolved Hide resolved

0xBigBoss added 4 commits June 6, 2023 17:00

clean up utility and servicer module

025b4ed

fallback to client context namespace

e1fb8f6

changelogs

4302a8f

Merge remote-tracking branch 'upstream/main' into 0xbigboss/dw-1860/c…

452e7f5

…ore-deploying-all-the-actors

0xBigBoss requested a review from Olshansk June 7, 2023 12:04

Olshansk added this to the M3: Pocket RoS (Relay or Slash) milestone Jun 7, 2023

Olshansk approved these changes Jun 7, 2023

View reviewed changes

rm ./var directory

fe90c0d

0xBigBoss merged commit dbc0deb into main Jun 8, 2023

0xBigBoss deleted the 0xbigboss/dw-1860/core-deploying-all-the-actors branch June 8, 2023 03:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Core] Deploying all-the-protocol-actors #710

[Core] Deploying all-the-protocol-actors #710

0xBigBoss commented Apr 30, 2023 •

edited

Loading

Olshansk left a comment

Olshansk left a comment

okdas left a comment

0xBigBoss commented May 7, 2023

Olshansk commented May 12, 2023

0xBigBoss commented Jun 6, 2023

Olshansk left a comment

0xBigBoss commented Jun 7, 2023

Olshansk left a comment

0xBigBoss commented Jun 8, 2023

[Core] Deploying all-the-protocol-actors #710

[Core] Deploying all-the-protocol-actors #710

Conversation

0xBigBoss commented Apr 30, 2023 • edited Loading

Description

Issue

Type of change

List of changes

Testing

Required Checklist

If Applicable Checklist

Olshansk left a comment

Choose a reason for hiding this comment

Olshansk left a comment

Choose a reason for hiding this comment

okdas left a comment

Choose a reason for hiding this comment

0xBigBoss commented May 7, 2023

Olshansk commented May 12, 2023

0xBigBoss commented Jun 6, 2023

Olshansk left a comment

Choose a reason for hiding this comment

0xBigBoss commented Jun 7, 2023

Olshansk left a comment

Choose a reason for hiding this comment

0xBigBoss commented Jun 8, 2023

0xBigBoss commented Apr 30, 2023 •

edited

Loading