JsonRpcProvider: Basic access authentication support #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kutoft
approved these changes
Feb 16, 2024
This could also be helpful in the READ.ME |
msmania
force-pushed
the
toshi/provider-basic-auth
branch
from
6cee631 to
ca11c1c
Compare
With this patch, `JsonRpcProvider` accepts a url with basic authentication credentials like this: ``` const PoktEndpoint = 'https://scott:[email protected]'; const provider = new JsonRpcProvider({ rpcUrl: PoktEndpoint, dispatchers: [PoktEndpoint], }); ```
msmania
force-pushed
the
toshi/provider-basic-auth
branch
from
ca11c1c to
db5a3bb
Compare
msmania
requested review from
Olshansk and
nodiesBlade
and removed request for
kutoft
nodiesBlade
previously approved these changes
Mar 10, 2024
nodiesBlade
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch,
JsonRpcProvideraccepts a url with basic authentication credentials like this: