Fix: Handle inaccessible file paths in fileSystemSource
to prevent crashes
#4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the handling of file system events within the
fileSystemSource
function. The problem arises when theopen
function, used to create a file descriptor for monitoring file system events, fails and returns-1
. This typically happens when the system lacks access to the specified file path, either due to permissions or other constraints. If this invalid file descriptor (-1
) is passed toDispatchSource.makeFileSystemObjectSource
, the application crashes.The behavior of the
open
function is defined in the POSIX documentation, which states that it returns-1
when access to the path fails.While one could argue that it's a developer error to pass an invalid URL, and I generally agree with this perspective, the liblery could be used by one to provide a functionality for users where they can access files in custom locations. This PR makes such a use case more robust by handling this situation gracefully.