Decouple database dependency from GRDBQueryKey #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If developers are to rely on the GRDB example as a guide for GRDB integration, it may be better to actually decouple the database dependency from
GRDBQueryKey
. Although everything currently works as-is because everything falls under the same namespace, I am finding that I can't simply copy and pasteGRDBQueryKey
code into myComposableArchitectureExtensions
library because the initializer has a database dependency that would be more appropriate to have in a separate library (e.g.LocalDatabaseClient
).I also think this is the way to go because I read somewhere in the Slack channel that the way Point-Free will be supporting GRDB isn't through some official code in the swift-sharing library itself, but rather an example that users can then copy-and-paste (which means it would be on us to maintain it after the code has made its way to our own codebases).