Fix subscript setter #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `set`/`modify` of `identifiedArray[n]` both assume an in-place replacement of the same identity. This makes sense for `_modify`, but not `set`, which can replace a value with one that has a totally new identity.
mbrandonw
approved these changes
Apr 25, 2024
stephencelis
added a commit
that referenced
this pull request
May 13, 2024
PR #66 fixed one issue but introduced a regression. This PR changes the subscript setter to do a `swap` when identity of elements match something that already exists in the collection. I've also stubbed out a fake property testing suite that can hopefully be expanded with more operations soon. Fixes #69.
stephencelis
added a commit
that referenced
this pull request
May 17, 2024
* Fix subscript set operation PR #66 fixed one issue but introduced a regression. This PR changes the subscript setter to do a `swap` when identity of elements match something that already exists in the collection. I've also stubbed out a fake property testing suite that can hopefully be expanded with more operations soon. Fixes #69. * wip * wip * wip * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
set/modifyofidentifiedArray[n]both assume an in-place replacement of the same identity. This makes sense for_modify, but notset, which can replace a value with one that has a totally new identity.