Relax game name matching when creating a table #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users are unlikely to have memorised the exact wording and orthography of the titles of games, so lets work harder to understand what they mean. Some examples: - `6 nimmt!` ↦ `sixnimmt` - `Gaïa` ↦ `gaia` - `Gear & Piston` ↦ `gearandpiston` - `The Voyages of Marco Polo` ↦ `marcopolo` - `Marco Polo II: In the Service of the Khan` ↦ `marcopolotwo`
|
I like this idea. Can you add a bunch of test cases against your There are also a couple games that you're checking for that I'm not familiar with. |
|
Tests added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are unlikely to have memorised the exact wording and orthography of the titles of games, so lets work harder to understand what they mean.
Some examples:
6 nimmt!↦sixnimmtGaïa↦gaiaGear & Piston↦gearandpistonThe Voyages of Marco Polo↦marcopoloMarco Polo II: In the Service of the Khan↦marcopolotwo