Remove protoc dep, use new MerkleTree methods, fix Agreement. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
changed the title
vkomenda
reviewed
May 18, 2018
| if message.epoch() < self.epoch { | ||
| return Ok(()); // Message is obsolete: We are already in a later epoch. | ||
| } | ||
| if message.epoch() > self.epoch { |
vkomenda
reviewed
May 18, 2018
| .push_back(AgreementMessage::BVal(self.epoch, b)); | ||
| // Receive the BVAL message locally. | ||
| let our_uid = self.uid.clone(); | ||
| self.handle_bval(&our_uid, b) |
vkomenda
reviewed
May 18, 2018
| @@ -178,32 +190,35 @@ impl<NodeUid: Clone + Debug + Eq + Hash> Agreement<NodeUid> { | |||
| self.messages | |||
| .push_back(AgreementMessage::Aux(self.epoch, b)); | |||
| // Receive the AUX message locally. | |||
| self.received_aux.insert(self.uid.clone(), b); | |||
| let our_uid = self.uid.clone(); | |||
| self.handle_aux(&our_uid, b)?; | |||
vkomenda
reviewed
May 18, 2018
| self.send_bval(b)?; | ||
| let queued_msgs = mem::replace(&mut self.incoming_queue, Vec::new()); | ||
| for (sender_id, msg) in queued_msgs { | ||
| self.handle_message(&sender_id, msg)?; |
There was a problem hiding this comment.
Here is one possible place for introducing spam control. I've no idea though how to avoid spam apart from using a set instead of Vec of queued messages and filtering out messages with unknown sender IDs. The latter is already done at the top level.
There was a problem hiding this comment.
That's true. Basically we just need to store per epoch: who sent us which BVals and which Aux.
We still might want to limit the number of future epochs somehow. On the other hand, that wouldn't be strictly correct…
There was a problem hiding this comment.
I created a new issue for this: #43
vkomenda
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.