Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth tombstones #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Auth tombstones #27

wants to merge 3 commits into from

Conversation

BobGerman
Copy link
Contributor

This PR would remove two samples, da-repairs-oauth and da-repairs-oauth-validated, because they are no longer relevant since Teams Toolkit stopped using Easy Auth in declarative agents as of v5.20.

@ericsche - this should remove the need for your PR, #14 which would change the approach to handling the local debug case where Easy Auth is missing. TTK has addressed this in the standard template. Glad to discuss.

Thanks!

@waldekmastykarz
Copy link
Member

To me, Easy Auth is a valid way to implement auth, that we should recommend that developers use. For me, it's more secure that doing auth yourself, because it keeps developers on rails. Auth isn't trivial and to do it correctly, you need to have a solid understanding of it. When implementing auth yourself, it's way too easy to miss something crucial and introduce a vulnerability.

Another thing in favor of Easy Auth is, that it's also managed by Microsoft which means that it's kept up to date with the latest findings. I'm aware that not everyone wants or can use Easy Auth, which is why it's good to have options.

Us showing samples isn't related to Teams Toolkit, so even if the tool chooses to show a way to build apps, we can still show alternatives here, in case someone prefers that approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants