Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): use double quotes in scripts #2954

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jan 13, 2025

Summary

  • Replaced single quotes ' with double quotes " in package.json scripts for the following reasons:
    • Cross-platform compatibility: Double quotes ensure consistent behavior across Unix and Windows environments, as Windows CMD struggles with single quotes.
    • Standardizes the format: Aligns with the existing fix:format script for consistency.
    • Follows official guidelines: The use of double quotes is recommended in the official documentation ensuring best practices are followed.

Check List

  • pnpm run fix:format for formatting code and docs

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:56pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 13, 2025

Open in Stackblitzdemostarter

npm i https://pkg.pr.new/zustand@2954

commit: 5cfe1f0

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if we were really able to support Windows, but this looks good.

@dai-shi dai-shi merged commit 2fc9f8d into pmndrs:main Jan 14, 2025
28 checks passed
@sukvvon sukvvon deleted the chore/replace-single-to-double-quotes branch January 14, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants