chore(rollup): migrate commonjs to esmodule

[sukvvon]

Summary

• LIke eslint.config.mjs, migrate rollup.config.js to rollup.config.mjs

Check List

• pnpm run fix:format for formatting code and docs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zustand-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 7, 2025 4:21am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[pkg-pr-new]

Open in Stackblitz • demo • starter

npm i https://pkg.pr.new/zustand@2939

commit: 89173fb

[dai-shi]

we should make sure that the resulting dist doesn't change a single byte with this change.

[sukvvon]

@dai-shi

we should make sure that the resulting dist doesn't change a single byte with this change.

Based on my observation, the size of the dist folder has not changed. The previous dist and the current dist code are identical.

Do you know a reliable way to accurately check the size of the dist folder?

[dai-shi]

Do you know a reliable way to accurately check the size of the dist folder?

Checking size in't enough. diff -r should do.

[sukvvon]

@dai-shi

Do you know a reliable way to accurately check the size of the dist folder?

Checking size in't enough. diff -r should do.

diff -r before_dist after_dist

I executed the above command and confirmed that there are no changes.

[dai-shi]

Looks good. Let's do the same for valtio and jotai.

[dai-shi]

@sukvvon Reusing a PR is better than closing and reopening it. Hope you find out the way next time.

[sukvvon]

@dai-shi

@sukvvon Reusing a PR is better than closing and reopening it. Hope you find out the way next time.

It was my mistake. When i saw this page, Merge button was disabled, so i thought it's hard to merge main into this branch, but after i saw it in my editor, i realize it's not. I will do better next time.

[sukvvon]

@dai-shi Thanks your advice. 🙇🏻‍♂️