Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(.github/workflows): change 'node-version' to 'lts/*' in 'actions/setup-node' #2933

Merged
merged 5 commits into from
Jan 4, 2025
Merged

chore(.github/workflows): change 'node-version' to 'lts/*' in 'actions/setup-node' #2933

merged 5 commits into from
Jan 4, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jan 3, 2025 •
edited
Loading

Summary

  • Change node-version to lts/* to always use the latest LTS version of Node.js.

Check List

  • pnpm run prettier for formatting code and docs

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 1:32am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 3, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 3, 2025 •
edited
Loading

Open in Stackblitz • demo • starter

npm i https://pkg.pr.new/zustand@2933

commit: 61e1bc3

@sukvvon sukvvon changed the title chore(.github/workflows): update 'node-version' to 22 in 'actions/setup-node' chore(.github/workflows): update 'node-version' to 'lts/*' in 'actions/setup-node' Jan 3, 2025
@sukvvon sukvvon changed the title chore(.github/workflows): update 'node-version' to 'lts/*' in 'actions/setup-node' chore(.github/workflows): change 'node-version' to 'lts/*' in 'actions/setup-node' Jan 3, 2025
@dbritto-dev
Copy link
Collaborator

@dai-shi all yours

dai-shi
dai-shi reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was writing those two comments previously, but it's already resolved!

.github/workflows/compressed-size-action.yml Outdated
@@ -10,7 +10,7 @@ jobs:
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, what happens if we omit this line? Is it required?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or specify like lts?

dai-shi
dai-shi approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/actions/setup-node

The node-version input is optional. If not supplied, the node version from PATH will be used. However, it is recommended to always specify Node.js version and don't rely on the system one.

Yeah, lts/* seems good.

@dai-shi
Copy link
Member

dai-shi commented Jan 3, 2025

Can you also send two PRs to jotai and valtio?

@sukvvon
Copy link
Contributor Author

sukvvon commented Jan 3, 2025

Can you also send two PRs to jotai and valtio?

I'll do it all

This was referenced Jan 3, 2025
Merged
Merged
dai-shi
dai-shi requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a leftover?

.github/workflows/test-multiple-versions.yml Outdated Show resolved Hide resolved
@sukvvon sukvvon requested a review from dai-shi January 4, 2025 01:36
dai-shi
dai-shi approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution as always!

@dai-shi dai-shi merged commit 6759fcb into pmndrs:main Jan 4, 2025
28 checks passed
@sukvvon sukvvon deleted the chore/update-node-version-in-action branch January 4, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbritto-dev dbritto-dev dbritto-dev approved these changes

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sukvvon @dbritto-dev @dai-shi