-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(.github): add 'setup' composite action for 'pnpm' and 'node' setup #2932
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Open in Stackblitz • demo • starter
commit: |
with: | ||
node-version: 20 | ||
cache: 'pnpm' | ||
registry-url: 'https://registry.npmjs.org' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this line L12?
Unfortunately, I don't feel this increases readability. For me, it's worse. Unless this improves performance, let's close this. |
@sukvvon Speaking of performance, and as you seem pretty familiar with this kind of things, we have some issues in CI performance in Waku, and you are welcome to contribute there too. 😄 |
I understood what you said 🙋🏻♂️
Thanks your saying!🙇🏻♂️ |
Summary
.github/workflows
, i createsetup
composite action forpnpm
andnode
setup, and apply itCheck List
pnpm run prettier
for formatting code and docs