Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): add 'setup' composite action for 'pnpm' and 'node' setup #2932

Closed
wants to merge 2 commits into from

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jan 3, 2025

Summary

  • For removing duplicate settings in .github/workflows, i create setup composite action for pnpm and node setup, and apply it

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 1:56am

Copy link

codesandbox-ci bot commented Jan 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 3, 2025

Open in Stackblitzdemostarter

npm i https://pkg.pr.new/zustand@2932

commit: be7e3d7

@sukvvon sukvvon marked this pull request as draft January 3, 2025 01:58
@sukvvon sukvvon marked this pull request as ready for review January 3, 2025 02:04
with:
node-version: 20
cache: 'pnpm'
registry-url: 'https://registry.npmjs.org'
Copy link
Member

@dai-shi dai-shi Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this line L12?

@dai-shi
Copy link
Member

dai-shi commented Jan 3, 2025

Unfortunately, I don't feel this increases readability. For me, it's worse. Unless this improves performance, let's close this.

@dai-shi dai-shi closed this Jan 3, 2025
@dai-shi
Copy link
Member

dai-shi commented Jan 3, 2025

@sukvvon Speaking of performance, and as you seem pretty familiar with this kind of things, we have some issues in CI performance in Waku, and you are welcome to contribute there too. 😄

@sukvvon sukvvon deleted the chore/add-setup-composite-action branch January 3, 2025 02:39
@sukvvon
Copy link
Contributor Author

sukvvon commented Jan 3, 2025

@dai-shi

Unfortunately, I don't feel this increases readability. For me, it's worse. Unless this improves performance, let's close this.

I understood what you said 🙋🏻‍♂️

@sukvvon Speaking of performance, and as you seem pretty familiar with this kind of things, we have some issues in CI performance in Waku, and you are welcome to contribute there too. 😄

Thanks your saying!🙇🏻‍♂️

@dbritto-dev
Copy link
Collaborator

@dai-shi I down with you, the usage of composite is to compose complex things, not to shorten few lines. btw, @sukvvon keep me in the loop if you need some help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants