-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dev dependencies #2880
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Size Change: 0 B Total Size: 12 kB ℹ️ View Unchanged
|
"rollup-plugin-esbuild": "^6.1.1", | ||
"shelljs": "^0.8.5", | ||
"shx": "^0.3.4", | ||
"typescript": "^5.6.3", | ||
"typescript": "^5.7.2", | ||
"use-sync-external-store": "^1.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React 19 just got released, this needs to be updated to 1.4.0
as I don't think 1.2.2
supports R19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a dev dependency, and the peer dependency is specified as a range, so it shouldn't be the actual problem.
We will update it for the next release anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, "devDependecies" is not included in the published package.json.
See: https://unpkg.com/browse/[email protected]/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, ignore me. I doubt this is the issue indeed. I'll wait for the next release before trying R19 again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt this is the issue indeed. I'll wait for the next release before trying R19 again.
So, do you have an actual issue? The next release doesn't change it. Please report your issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just fixed the issue, one of my tests was throwing TypeError: Cannot read properties of null (reading 'useSyncExternalStore')
, turned out to be a dependency issue, fixed by adding zustand to devDeps...
I updated to R19 without an issue now. Thanks for your help!
for v5.0.2