Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dev dependencies #2880

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 4, 2024

for v5.0.2

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 1:15pm

Copy link

codesandbox-ci bot commented Dec 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Dec 4, 2024

Size Change: 0 B

Total Size: 12 kB

ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 64 B
./dist/esm/middleware.mjs 3.58 kB
./dist/esm/middleware/immer.mjs 210 B
./dist/esm/react.mjs 320 B
./dist/esm/react/shallow.mjs 193 B
./dist/esm/shallow.mjs 82 B
./dist/esm/traditional.mjs 411 B
./dist/esm/vanilla.mjs 403 B
./dist/esm/vanilla/shallow.mjs 523 B
./dist/index.js 244 B
./dist/middleware.js 3.59 kB
./dist/middleware/immer.js 229 B
./dist/react.js 336 B
./dist/react/shallow.js 208 B
./dist/shallow.js 189 B
./dist/traditional.js 423 B
./dist/vanilla.js 416 B
./dist/vanilla/shallow.js 535 B

compressed-size-action

@dai-shi dai-shi merged commit d454913 into main Dec 4, 2024
26 checks passed
@dai-shi dai-shi deleted the chore/update-dev-dependnecies branch December 4, 2024 14:55
"rollup-plugin-esbuild": "^6.1.1",
"shelljs": "^0.8.5",
"shx": "^0.3.4",
"typescript": "^5.6.3",
"typescript": "^5.7.2",
"use-sync-external-store": "^1.2.2",
Copy link
Contributor

@goosewobbler goosewobbler Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React 19 just got released, this needs to be updated to 1.4.0 as I don't think 1.2.2 supports R19

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a dev dependency, and the peer dependency is specified as a range, so it shouldn't be the actual problem.

We will update it for the next release anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, "devDependecies" is not included in the published package.json.
See: https://unpkg.com/browse/[email protected]/package.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, ignore me. I doubt this is the issue indeed. I'll wait for the next release before trying R19 again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this is the issue indeed. I'll wait for the next release before trying R19 again.

So, do you have an actual issue? The next release doesn't change it. Please report your issue.

Copy link
Contributor

@goosewobbler goosewobbler Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed the issue, one of my tests was throwing TypeError: Cannot read properties of null (reading 'useSyncExternalStore'), turned out to be a dependency issue, fixed by adding zustand to devDeps...

I updated to R19 without an issue now. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants