Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.21.50 support #6558

Closed
wants to merge 8 commits into from

Conversation

nicholass003
Copy link
Contributor

Introduction

This PR updates PM5 to 1.21.50

Changes

Backwards compatibility

See pmmp/BedrockProtocol#279

@nicholass003 nicholass003 requested a review from a team as a code owner December 4, 2024 06:44
@dktapps
Copy link
Member

dktapps commented Dec 4, 2024

We don't accept gameplay changes in protocol update PRs. There's too much noise.

@dktapps dktapps closed this Dec 4, 2024
@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Resolution: Declined PR has been declined by maintainers Category: Protocol Related to (changes in) the Minecraft network protocol Type: Enhancement Contributes features or other improvements to PocketMine-MP Multiple changes PR contains multiple changes and requires separation labels Dec 4, 2024
@dktapps
Copy link
Member

dktapps commented Dec 4, 2024

(Please don't split conversations between Discord and GitHub. Most of the team don't actively read the public Discord and I don't see messages unless someone forwards them to me.)

Thanks for attempting to contribute. Your effort is appreciated, but there are some things you should be aware of.

First, PRs should do the minimum amount of changes needed to achieve a single objective. This has always been the way in PMMP. Doesn't matter what type of PR it is.

The number 1 rule of pull requests is: keep it small & simple. Don't do unnecessary changes in a PR & don't combine multiple changes. Large PRs & PRs containing multiple changes are exponentially more time-consuming to review. Maintainers don't have time to waste trying to review large PRs that don't follow contribution guidelines.

Second, protocol updates are a closely coordinated effort within the PMMP team between multiple people. It doesn't make sense to involve outside collaborators, as it will just slow down the update process. As seen in #6559 one of our team already had the code ready to go. We appreciate the effort you made, but as this is a process that requires team communication, it didn't make sense to consider this PR.

If you want to get more involved with changes like this, you should communicate with the team.

You're welcome to submit separate PRs to add new gameplay features using the code from this PR.

@nicholass003
Copy link
Contributor Author

Thank you for the explanation, I understand, next I will discuss it with the team first before doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Category: Protocol Related to (changes in) the Minecraft network protocol Multiple changes PR contains multiple changes and requires separation Resolution: Declined PR has been declined by maintainers Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants