Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: end up the winding down period #371

Merged
merged 2 commits into from
Aug 30, 2023
Merged

common: end up the winding down period #371

merged 2 commits into from
Aug 30, 2023

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Aug 29, 2023 •
edited
Loading

  • remove banner from the main page
  • add banner to the template for all PMDK libraries
  • point the place where users can submit issues and ask questions
  • simplify the repoindex data structure in preparation for the upcoming refresh (a done-by-the-way change)

Preview:

This change is Reviewable

@janekmi
common: end up the winding down period
0fc0c09 
- remove banner from the main page
- add banner to the template for all PMDK libraries
- point the place where users can submit issues and ask questions

Signed-off-by: Jan Michalski <[email protected]>
@janekmi janekmi force-pushed the main branch 2 times, most recently from 3ef993d to d289f8a Compare August 30, 2023 08:52
grom72
grom72 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi requested a review from osalyk August 30, 2023 12:44
osalyk
osalyk reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

grom72
grom72 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit 047a0e2 into pmem:main Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osalyk osalyk osalyk left review comments

@grom72 grom72 grom72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janekmi @grom72 @osalyk