[NES-255] make pUSD a ComponentToken #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PSUpgradeable, ComponentToken
ungaro
changed the title
eyqs
reviewed
Nov 14, 2024
…(lines&functions), fix small problems with pUSD
…es, fix ERC20 functions mess
…ttoassets, previewredem, previewdeposit
eyqs
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM, feel free to review and address comments later. Only the comments for ComponentToken.sol and pUSD.sol matter because those are the only contracts being audited.
I think we should create a new package for just the BoringVault mocks and interfaces and import them in somehow so the Nest folder doesn't have all of these BoringVault related files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
make pUSD a ComponentToken.
need to have a second look and add tests..
WIP