Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NES-212] make YieldToken implement IComponentToken #91

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

eyqs
Copy link
Member

@eyqs eyqs commented Nov 11, 2024

What's new in this PR?

This allows us to put YieldTokens into AggregateTokens.

Why?

What problem does this solve?
Why is this important?
What's the context?

@eyqs eyqs added the enhancement New feature or request label Dec 3, 2024
Copy link
Contributor

@ungaro ungaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some outstanding comments to be reviewed.

smart-wallets/src/token/YieldToken.sol Show resolved Hide resolved
smart-wallets/src/token/YieldToken.sol Outdated Show resolved Hide resolved
smart-wallets/src/token/YieldToken.sol Outdated Show resolved Hide resolved
@eyqs eyqs merged commit 8931801 into main Dec 18, 2024
1 check passed
@eyqs eyqs deleted the eyqs/NES-212 branch December 18, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants