additional smart-wallet YieldDistributionTokenScenarioTest tests #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyqs
reviewed
Nov 10, 2024
|
|
||
| userState.amountSeconds += amountSecondsAccrued; | ||
|
|
||
| if (userState.amountSeconds > userState.amountSecondsDeduction) { | ||
| uint256 yieldAccruedBefore = userState.yieldAccrued; |
There was a problem hiding this comment.
Is there some way to enable / disable the console logs depending on whether we're debugging or pushing production code ? Remove yieldAccruedBefore and console2.log("\tyieldAccrued: %d", deposit.scaledCurrencyTokenPerAmountSecond.mulDiv(userState.amountSeconds - userState.amountSecondsDeduction, SCALE))
There was a problem hiding this comment.
i tried to look into this but didn't seem like there was anything. the console logs were just meant to be temporary while I was doing the tests but I'll dig into it a bit more
There was a problem hiding this comment.
looks like there isn't a way to do this with forge, only hardhat. I'll manually remove them before the final review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Add tests for YieldDistributionToekn
Why?
What problem does this solve?
Why is this important?
What's the context?