feat: make vault notification methods internal #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Make ComponentToken methods notifyDeposit and notifyRedeem internal.
Why?
ComponentToken methods notifyDeposit and notifyRedeem add public methods to the ABI. Issuers - such as Dinari - may implement other methods when extending ComponentToken which handle the transition of orders from pending to claimable.
Rather than have dead code in ComponentToken, this PR makes the current methods internal so they can be used to provide consistent notification events and arithmetic without adding opinionated methods to the ABI.
Example: dinaricrypto/sbt-contracts#374